Fix flaky table aggregation partition IT#17653
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17653 +/- ##
============================================
+ Coverage 40.36% 40.37% +0.01%
- Complexity 2554 2574 +20
============================================
Files 5177 5178 +1
Lines 349162 349085 -77
Branches 44673 44654 -19
============================================
+ Hits 140928 140934 +6
+ Misses 208234 208151 -83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The test could shut down DataNodes before IoTConsensus async replication had reached the DataNodes that would be restarted. If shutdown interrupted syncLogEntries, one replica could recover without the expected data and queries routed to it could fail.